Extend Scrutineer with GitHub Actions monitoring and evidence bundles - #124
Open
leynos wants to merge 1 commit into
Open
Extend Scrutineer with GitHub Actions monitoring and evidence bundles#124leynos wants to merge 1 commit into
leynos wants to merge 1 commit into
Conversation
Add explicit run and attempt selection, gh run watch guidance, failed-log capture, and a summary bundle for the summoning agent. Preserve existing gate, CodeRabbit, and provider contracts; pin the new guidance in tests.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedNext included review available in 10 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 81 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
Reviewer's GuideExtends Scrutineer with deterministic, read-only GitHub Actions monitoring that preserves run identity and failure evidence, packages results into a private summary bundle, and adds tests enforcing the new contract without weakening existing gate or CodeRabbit behavior. Sequence diagram for GitHub Actions evidence monitoringsequenceDiagram
participant S as Scrutineer
participant GH as GitHub CLI
participant B as Private evidence bundle
participant A as Summoning agent
S->>GH: gh run view --json status,conclusion,headSha,attempt,jobs,url
S->>GH: gh run watch --exit-status --interval 30
GH-->>S: watcher output and exit code
S->>GH: gh run view --attempt --json ...
alt completed non-successful run
S->>GH: gh run view --attempt --log-failed
GH-->>S: failed-step logs and retrieval status
alt logs empty or incomplete
S->>GH: gh run view --job --log
GH-->>S: full job logs and retrieval status
end
end
S->>B: Write metadata, logs, excerpts, and summary.md
S-->>A: Return verdict, bundle path, gaps, and next action
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the existing Scrutineer sub-agent with GitHub Actions monitoring through
gh run watch, alongside its deterministic gate execution and optional CodeRabbit review duties. The description now advertises all three capabilities and the summary-bundle hand-off to the summoning agent.Only
agents/subagents.ymlandtests/test_subagent_definitions.pychange. Other sub-agents, provider models, sandbox settings, and tool grants are unchanged.Monitoring and evidence contract
gh run watch --exit-status --interval 30, preserving output and exit status. Capture final attempt-specific metadata even after a nonzero watcher exit; do not confuse authentication/API errors with workflow failures.gh run view --attempt ... --log-failedon completed non-successful runs, with full job-log fallback from recorded job IDs. Keep retrieval errors separate from the workflow conclusion and report missing, expired, or inaccessible logs explicitly.summary.md, per-run metadata, watcher output, captured failure logs, retrieval stderr, exit codes, URLs, and bounded decisive excerpts. Provide a usable hand-off to the summoning agent rather than only a bare verdict.Validation
python -m pytest tests/test_subagent_definitions.py -q: 74 passed.set -euwith a localghstand-in across five success/failure combinations, confirming that watcher failures do not prevent metadata/failure-log capture and retrieval exit statuses remain distinct.git diff --checkpassed.Local validation used an isolated snapshot of the exact GitHub-sourced manifest, tests, and loader, with the original blobs verified against GitHub. Full repository
make ciwas not run locally, and the shell smoke checks are not authenticated live GitHub Actions integration tests. Hosted CI is a separate check.CLI references
Command flags and known limitations were checked against the official GitHub CLI documentation:
Base:
065863ab6b86bd97f7bf9254ec45b1ee28bebe2d.Summary by Sourcery
Extend Scrutineer with read-only GitHub Actions monitoring and evidence-bundle hand-off while preserving its deterministic gates and optional CodeRabbit review duties.
New Features:
Enhancements:
Tests: