Fix for issue 4313 selector list not expanding#4314
Open
puckowski wants to merge 14 commits intoless:masterfrom
Open
Fix for issue 4313 selector list not expanding#4314puckowski wants to merge 14 commits intoless:masterfrom
puckowski wants to merge 14 commits intoless:masterfrom
Conversation
* Add support for CSS container query scroll-state.
* Fix an issue where selector with comma would not expand correctly.
* Make fix for issue less#4313 selector list not expanding correctly more flexible.
* Add more tests for fix for issue less#4313.
* Cleanup merge issues for fix for issue less#4313.
Contributor
Author
|
Looks like CI may have an issue. Tests pass locally for me. |
Contributor
Author
|
I re-ran CI but ran into issues. Branch passes all tests locally for me. I wouldn't expect files changed to impact CI (two test files, one source file). Would you be able to take a look? @iChenLei |
* Revise CI for missing browser issue.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Trying to resolve CI issues with Playwright.
* Fix CI by pinning CI version to resolve incorrect browser binary downloads.
Contributor
Author
|
FYI figured out the new CI issue. Had to revise CI file to pin Playwright version to resolve browser binary mismatches. @iChenLei @matthew-dean See files changed in this PR. |
WORMSS
reviewed
Feb 1, 2025
* Improve CI stability by only grabbing patch updates. This may when npm install runs we will not download a version of Playwright which will be incompatible with the browser binaries installed by CI. * Add CI code comments about the Playwright issue that we ran into.
* Remove package.json changes per master branch updates.
* Cleanup CI changes per master branch updates to CI.
Contributor
Author
|
PR was updated and is now more narrow in scope. Let me know if you have an opportunity to review. @matthew-dean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
PR contains a fix for issue #4313 selector list not expanding with & symbol.
Why:
In Less.js version 4.2.2, this Less:
produces the incorrect CSS:
the & symbol should now be properly expanded with the fix.
Checklist: