Skip to content

[Merged by Bors] - fix(scripts/runSkimmer): only lake update skimmer#41662

Closed
thorimur wants to merge 1 commit into
leanprover-community:masterfrom
thorimur:sideskimmer-fix
Closed

[Merged by Bors] - fix(scripts/runSkimmer): only lake update skimmer#41662
thorimur wants to merge 1 commit into
leanprover-community:masterfrom
thorimur:sideskimmer-fix

Conversation

@thorimur

@thorimur thorimur commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Previously, runSkimmer.sh would run lake update, thus potentially erroneously updating packages from mathlib in its own .lake/packages. By using lake update skimmer we ensure that only skimmer itself (which depends on nothing) is updated, and we match the mathlib dependencies to whatever mathlib already has. This ensures that we're able to use the mathlib cache.

Note: this still clones every package into scripts/SideSkimmer/.lake/packages/—but by cloning the right version, we can use the cache.


To test this locally, check out the PR, run lake exe cache get and (assuming you get a full cache) run scripts/runSkimmer.sh. It should do a little bit of setup, then zoom through all of its jobs (successfully applying all 0 try-this suggestions). :)

Open in Gitpod

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

PR summary 65b5e1097d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 65b5e10).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 65b5e1097d
Reference commit f34e762642

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions Bot added the CI Modifies the continuous integration setup or other automation label Jul 12, 2026
@thorimur thorimur changed the title fix(runSkimmer.sh): only lake update skimmer fix(scripts/runSkimmer.sh): only lake update skimmer Jul 12, 2026
@thorimur thorimur changed the title fix(scripts/runSkimmer.sh): only lake update skimmer fix: (scripts/runSkimmer.sh) only lake update skimmer Jul 12, 2026
@thorimur thorimur changed the title fix: (scripts/runSkimmer.sh) only lake update skimmer fix(scripts/runSkimmer): only lake update skimmer Jul 12, 2026
@thorimur thorimur added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 12, 2026
@grunweg

grunweg commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Thanks! I'll trust that you caught all the places to fix (and in any case, this seems like an improvement even if missing one), so:
bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 13, 2026
Previously, `runSkimmer.sh` would run `lake update`, thus potentially erroneously updating packages from mathlib in its own `.lake/packages`. By using `lake update skimmer` we ensure that only skimmer itself (which depends on nothing) is updated, and we match the mathlib dependencies to whatever mathlib already has. This ensures that we're able to use the mathlib cache.

Note: this still clones every package into `scripts/SideSkimmer/.lake/packages/`—but by cloning the right version, we can use the cache.
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 13, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title fix(scripts/runSkimmer): only lake update skimmer [Merged by Bors] - fix(scripts/runSkimmer): only lake update skimmer Jul 13, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. CI Modifies the continuous integration setup or other automation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants