[Merged by Bors] - fix(scripts/runSkimmer): only lake update skimmer#41662
[Merged by Bors] - fix(scripts/runSkimmer): only lake update skimmer#41662thorimur wants to merge 1 commit into
lake update skimmer#41662Conversation
PR summary 65b5e1097dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
lake update skimmerlake update skimmer
lake update skimmerlake update skimmer
lake update skimmerlake update skimmer
|
Thanks! I'll trust that you caught all the places to fix (and in any case, this seems like an improvement even if missing one), so: |
Previously, `runSkimmer.sh` would run `lake update`, thus potentially erroneously updating packages from mathlib in its own `.lake/packages`. By using `lake update skimmer` we ensure that only skimmer itself (which depends on nothing) is updated, and we match the mathlib dependencies to whatever mathlib already has. This ensures that we're able to use the mathlib cache. Note: this still clones every package into `scripts/SideSkimmer/.lake/packages/`—but by cloning the right version, we can use the cache.
|
Pull request successfully merged into master. Build succeeded: |
lake update skimmerlake update skimmer
Previously,
runSkimmer.shwould runlake update, thus potentially erroneously updating packages from mathlib in its own.lake/packages. By usinglake update skimmerwe ensure that only skimmer itself (which depends on nothing) is updated, and we match the mathlib dependencies to whatever mathlib already has. This ensures that we're able to use the mathlib cache.Note: this still clones every package into
scripts/SideSkimmer/.lake/packages/—but by cloning the right version, we can use the cache.To test this locally, check out the PR, run
lake exe cache getand (assuming you get a full cache) runscripts/runSkimmer.sh. It should do a little bit of setup, then zoom through all of its jobs (successfully applying all 0 try-this suggestions). :)