Skip to content

feat(Topology/Connected): connected and path components of products and pi types#41661

Open
korbonits wants to merge 1 commit into
leanprover-community:masterfrom
korbonits:path-component-prod-pi
Open

feat(Topology/Connected): connected and path components of products and pi types#41661
korbonits wants to merge 1 commit into
leanprover-community:masterfrom
korbonits:path-component-prod-pi

Conversation

@korbonits

@korbonits korbonits commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Add connectedComponent_prod/pi and pathComponent_prod/pi: the (path) component of a point in a product is the product of the components of its coordinates. Also add the missing Joined.map, Joined.prod, Joined.pi along the way.

Follow-up to #40092.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 12, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Jul 12, 2026
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

PR summary a1e3877848

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Joined.map
+ Joined.pi
+ Joined.prod
+ connectedComponent_pi
+ connectedComponent_prod
+ pathComponent_pi
+ pathComponent_prod

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a1e3877).

  • +7 new declarations
  • −0 removed declarations
+Joined.map
+Joined.pi
+Joined.prod
+connectedComponent_pi
+connectedComponent_prod
+pathComponent_pi
+pathComponent_prod

No changes to strong technical debt.

No changes to weak technical debt.

Current commit a1e3877848
Reference commit f34e762642

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@korbonits

Copy link
Copy Markdown
Contributor Author

LLM-generated

@github-actions github-actions Bot added the LLM-generated PRs with substantial input from LLMs - review accordingly label Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LLM-generated PRs with substantial input from LLMs - review accordingly new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant