chore: rename QuotientAddGroup.mk_out_eq_mul to mk_out_eq_add#41654
Open
adomani wants to merge 1 commit into
Open
chore: rename QuotientAddGroup.mk_out_eq_mul to mk_out_eq_add#41654adomani wants to merge 1 commit into
QuotientAddGroup.mk_out_eq_mul to mk_out_eq_add#41654adomani wants to merge 1 commit into
Conversation
The additive lemma states `(mk g).out = g + h`, so by the `to_additive` naming convention (`mul → add`) its name should end in `add`, not `mul`. The `_mul` spelling is a long-standing copy-paste error inherited from mathlib3 (the `#align quotient_add_group.mk_out'_eq_mul` from the original port kept the multiplicative token when only the namespace was additivised). Rename the additive declaration to `QuotientAddGroup.mk_out_eq_add` and keep the old name as a deprecated alias. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PR summary 1ea2e3df23Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The additive lemma states
(mk g).out = g + h, so by theto_additivenaming convention its name should end inadd, notmul. Renames it toQuotientAddGroup.mk_out_eq_add(a copy-paste error inherited from mathlib3) and deprecates the old name.