chore: add missing to_additive docstrings in Combinatorics and Dynamics#41645
Open
adomani wants to merge 3 commits into
Open
chore: add missing to_additive docstrings in Combinatorics and Dynamics#41645adomani wants to merge 3 commits into
to_additive docstrings in Combinatorics and Dynamics#41645adomani wants to merge 3 commits into
Conversation
…mics For each declaration in these files that carries a hand-written doc-string but whose `to_additive` counterpart was missing one, this adds the additive doc-string (a simple-minded multiplicative-to-additive translation, with referenced lemma names translated to their additive versions). Part of a split of the `to_additive` doc-string sweep into reviewable chunks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PR summary c44884d54eImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
b-mehta
approved these changes
Jul 13, 2026
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Rebalance the additive `IsAddFreimanIso.symm` doc-string across two lines to satisfy the 100-character long-line lint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing additive doc-strings (multiplicative side has a hand-written doc-string, additive side did not) across 5 file(s) in Combinatorics and Dynamics.
The additive doc-strings are simple-minded translations of the multiplicative ones, with referenced lemma names replaced by their
to_additivecounterparts. These gaps were found by an environment linter that pairs each declaration with itsto_additivecounterpart and checks that both or neither is documented.🤖 Generated with Claude Code