Return uncached sections in getSections() method#124
Open
Nightenom wants to merge 1 commit intoversion/mainfrom
Open
Return uncached sections in getSections() method#124Nightenom wants to merge 1 commit intoversion/mainfrom
Nightenom wants to merge 1 commit intoversion/mainfrom
Conversation
Raycoms
reviewed
Feb 18, 2026
| { | ||
| // don't cache them | ||
| return new LevelChunkSection[0]; | ||
| final FakeLevelChunkSection[] sections = new FakeLevelChunkSection[fakeLevel.getSectionsCount()]; |
Contributor
There was a problem hiding this comment.
Should we cache this maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes on our end ldtteam/Structurize#799
Changes proposed in this pull request
Testing
Review please