Skip to content

fix: disabled hmr#384

Merged
lazarv merged 2 commits intomainfrom
fix/disabled-hmr
Apr 9, 2026
Merged

fix: disabled hmr#384
lazarv merged 2 commits intomainfrom
fix/disabled-hmr

Conversation

@lazarv
Copy link
Copy Markdown
Owner

@lazarv lazarv commented Apr 9, 2026

Do not viteDevServer.environments.client.hot.listen() when HMR is disabled.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

⚡ Benchmark Results

PR cdfddc4 main 70a320f
Config 50 connections, 10s/test 50 connections, 10s/test
Benchmark Req/s vs main Avg Latency vs main P99 Latency Throughput
minimal 1167 🔴 -9.2% 42.22 ms 🔴 +10.2% 81 ms 0.7 MB/s
small 1288 🔴 -3.3% 38.28 ms 🔴 +3.5% 68 ms 1.2 MB/s
medium 333 🔴 -1.2% 148.76 ms ⚪ +0.9% 218 ms 4.9 MB/s
large 32 🟢 +7.0% 1481.7 ms 🟢 -1.8% 2390 ms 3.2 MB/s
deep 854 🔴 -3.8% 57.78 ms 🔴 +3.5% 99 ms 2.8 MB/s
wide 40 🔴 -6.3% 1138.8 ms ⚪ +0.7% 2134 ms 2.2 MB/s
cached 3345 🔴 -5.0% 14.5 ms 🔴 +6.1% 31 ms 48.8 MB/s
client-min 456 🟢 +1.2% 108.91 ms ⚪ -1.0% 166 ms 2.3 MB/s
client-small 466 ⚪ -0.8% 106.2 ms 🔴 +1.1% 148 ms 2.5 MB/s
client-med 355 ⚪ -1.0% 139.91 ms 🔴 +1.4% 200 ms 6.8 MB/s
client-large 89 🟢 +2.3% 550.84 ms ⚪ +0.2% 1020 ms 9.4 MB/s
client-deep 462 🟢 +3.3% 107.24 ms 🟢 -3.0% 153 ms 3.6 MB/s
client-wide 144 🟢 +3.1% 339.49 ms 🟢 -3.3% 522 ms 8.5 MB/s
static-json 6977 🟢 +2.2% 6.64 ms 🟢 -1.8% 16 ms 2.9 MB/s
static-js 6859 🔴 -1.9% 6.74 ms 🔴 +2.0% 16 ms 8.2 MB/s
404-miss 4857 🔴 -3.1% 9.72 ms 🔴 +1.7% 21 ms 0.6 MB/s
hybrid-min 467 🟢 +2.5% 106.16 ms 🟢 -2.2% 159 ms 2.6 MB/s
hybrid-small 454 🟢 +4.6% 109.16 ms 🟢 -4.6% 160 ms 3.0 MB/s
hybrid-medium 204 🟢 +6.7% 239.04 ms 🟢 -7.5% 361 ms 9.2 MB/s
hybrid-large 25 ⚪ 0.0% 1763.87 ms 🟢 -1.4% 3814 ms 8.5 MB/s
hybrid-deep 350 🟢 +1.5% 141.78 ms 🟢 -1.6% 213 ms 5.2 MB/s
hybrid-wide 33 🟢 +3.4% 1403.2 ms 🟢 -1.6% 3262 ms 7.3 MB/s
hybrid-cached 2908 🟢 +3.2% 16.73 ms 🟢 -2.8% 33 ms 130.2 MB/s
hybrid-client-min 492 ⚪ +0.0% 100.91 ms ⚪ +0.3% 151 ms 2.5 MB/s
hybrid-client-small 489 🟢 +2.0% 101.15 ms 🟢 -2.0% 151 ms 2.7 MB/s
hybrid-client-medium 367 🟢 +3.4% 134.44 ms 🟢 -3.8% 195 ms 7.1 MB/s
hybrid-client-large 88 ⚪ +0.8% 554.26 ms 🟢 -1.4% 942 ms 9.3 MB/s
hybrid-client-deep 454 🟢 +2.2% 109.17 ms 🟢 -2.1% 155 ms 3.6 MB/s
hybrid-client-wide 145 ⚪ +0.4% 334.29 ms ⚪ +0.0% 604 ms 8.6 MB/s
Legend

🟢 > 1% improvement | 🔴 > 1% regression | ⚪ within noise margin

Benchmarks run on GitHub Actions runners (shared infrastructure) — expect ~5% variance between runs. Consistent directional changes across multiple routes are more meaningful than any single number.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
922 1 921 3
View the top 1 failed test(s) by shortest run time
__test__/scroll-restoration.spec.mjs > scroll restoration: multiple back/forward preserves positions
Stack Traces | 27.9s run time
AssertionError: expected 0 to be greater than 400
 ❯ __test__/scroll-restoration.spec.mjs:158:25

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@lazarv lazarv merged commit 86b9414 into main Apr 9, 2026
143 of 145 checks passed
@lazarv lazarv deleted the fix/disabled-hmr branch April 9, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants