Skip to content

chore: upgrade Go version to 1.26.4#218

Open
smishraa30 wants to merge 1 commit into
layer5io:masterfrom
smishraa30:fix/upgrade-go-1.26.4
Open

chore: upgrade Go version to 1.26.4#218
smishraa30 wants to merge 1 commit into
layer5io:masterfrom
smishraa30:fix/upgrade-go-1.26.4

Conversation

@smishraa30

Copy link
Copy Markdown

Changes

  • Updated go.mod Go version from 1.24 to 1.26.4
  • Updated go-version in .github/workflows/bump-academy-version.yml

Fixes #217

- Updated go.mod to use Go 1.26.4
- Updated GitHub Actions workflow go-version to 1.26.4

Fixes layer5io#217

Signed-off-by: Shivam <smishraa30@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version in go.mod to 1.26.4 and removes the github.com/google/docsy dependency along with all entries in go.sum. Feedback indicates that Go 1.26 is not yet released, making the specified version invalid, and that removing the Docsy dependency will break the Hugo build since the theme relies on it. A suggestion is provided to use a valid Go version and retain the Docsy dependency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread go.mod
go 1.24.5

require github.com/google/docsy v0.12.0 // indirect
go 1.26.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Go version 1.26.4 is invalid because Go 1.26 has not been released yet. Additionally, removing the github.com/google/docsy dependency will break the Hugo build as this theme relies on Docsy. Please use a valid Go version (such as 1.24.0) and retain the Docsy dependency.

Suggested change
go 1.26.4
go 1.24.0
require github.com/google/docsy v0.12.0 // indirect

@leecalcote leecalcote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request assignment of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade project to go1.26.4

2 participants