[CI] Upgrade project to Go 1.26.4#151
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to upgrade the Go version from 1.24.5 to 1.26.4 in both the Makefile and go.mod. However, Go 1.26.4 is not a released version, which will lead to build and CI pipeline failures. Both review comments correctly point out this issue and suggest reverting to a valid, stable Go version.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Fixes layer5io#149 Signed-off-by: Kumar Nirupam <kumar.nirupam24@gmail.com>
KumarNirupam1
force-pushed
the
feature/update/go1.26.4
branch
from
948cc5d to
5e97ad8
Compare
Required for org-id shortcode used in content formatting examples. Fixes CI build failure. Signed-off-by: Kumar Nirupam <kumar.nirupam24@gmail.com> Signed-off-by: Kumar Nirupam <kumar.nirupam24@gmail.com>
|
🚀 Preview deployment: https://layer5io.github.io/academy-example/pr-preview/pr-151/
|
|
@leecalcote @CodexRaunak the PR is ready to review |
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
Updates to workflows is missing.
Signed-off-by: Kumar Nirupam <kumar.nirupam24@gmail.com>
|
@leecalcote added Setup Go to The preview/deploy workflows already read Go version from go.mod, so no changes needed there. |
|
@Sbragul26 Thanks for the review you're right that make setup and make build don't call go directly. Hugo still uses the Go toolchain behind the scenes for Hugo Modules (e.g. when resolving academy-theme during hugo: collected modules). I added the Setup Go step here to align with build-and-preview-site.yml and build-and-deploy-site.yml, which already use go-version-file: go.mod, after lee's feedback that workflow updates were missing. |
|
Should we also add a |
|
ok so since this workflow uses npm through make setup |
Signed-off-by: Kumar Nirupam <kumar.nirupam24@gmail.com>
3 participants
Notes for Reviewers
This PR fixes #149
Changes
Go 1.26.4 upgrade — Updates
go.modand.github/build/Makefile.core.mkfrom 1.24.5 to 1.26.4. CI workflows already usego-version-file: go.mod, so no workflow changes were required.academy-theme v0.4.17 — Bumps
github.com/layer5io/academy-themefrom v0.4.16 → v0.4.17 to fix a CI build failure.Why the theme bump?
masterincludescontent/content-formatting-examples/academy-theme/org-id.md, which uses the{{< org-id >}}shortcode. That shortcode was added in academy-theme v0.4.17 and is not present in v0.4.16.Without the theme bump,
make build-previewfails with:Signed commits