fix: add busy progress affordance to new tabs and remove dead placeholder fields#1161
Merged
Merged
Conversation
…lder fields - Resource History, Scheduled Maintenance, and Tweaks Hub set IsBusy around their async work but never surfaced it. Added the sibling CleanupView ProgressBar pattern (indeterminate bar next to the status line, visible while IsBusy) so the user gets feedback during loads/applies/schedule changes. - Removed 8 orphaned Wip* PlaceholderViewModel fields (FileLockDetector, StandbyListCleaner, TimerResolution, CpuAffinity, DisplayProfiles, DefenderTweaks, DarkModeScheduler, TaskScheduler) left behind after those features graduated to real tabs — they were declared, allocated in InitPlaceholders, and disposed every launch but referenced in no nav group (verified: zero usage outside the declarations). Pure dead-code removal, no behavior change. No new/changed tests: the removal is covered by the existing nav-count integration tests (still 58 items / 12 groups), the ProgressBar is presentation-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Final post-feature-audit cleanup (Batch 6 of 6).
Changes
IsBusyaround their async work but never surfaced it. Added the siblingCleanupViewpattern — an indeterminateProgressBarnext to the status line, visible whileIsBusy— so the user gets feedback during loads / applies / schedule changes instead of a silent pause.Wip*PlaceholderViewModelfields (FileLockDetector, StandbyListCleaner, TimerResolution, CpuAffinity, DisplayProfiles, DefenderTweaks, DarkModeScheduler, TaskScheduler) left behind after those features graduated to real tabs. They were declared, allocated inInitPlaceholders, and disposed every launch but referenced in no nav group (verified: zero usage outside the declarations). Pure cleanup, no behavior change.Tests
No new tests: the removal is covered by the existing nav-count integration tests (still 58 items / 12 groups, all green), and the ProgressBar is presentation-only.
Docs
CHANGELOG 1.51.6, version bump to 1.51.6.
Completes the post-feature audit remediation (6 of 6).