feat: fall back to model.parameters.tools when root tools absent#1330
Draft
jsonbailey wants to merge 3 commits intomainfrom
Draft
feat: fall back to model.parameters.tools when root tools absent#1330jsonbailey wants to merge 3 commits intomainfrom
jsonbailey wants to merge 3 commits intomainfrom
Conversation
When root-level tools is absent, fall back to model.parameters.tools and parse it as our LDTool map format. Arrays or entries missing a name field are silently ignored. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
jsonbailey
changed the title
…s bad entries Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolveTools()toLDAIConfigUtils— checks root-leveltoolsfirst, falls back tomodel.parameters.toolsfor older AI configstoolsalways takes priority when presentmodel.parameters.toolsas an array or non-object is silently ignored (may be user-defined custom param)namestring are silently skipped; valid entries in the same map are still returnedBackground
The LaunchDarkly AI Config API now sends tools in two places: updated configs send them at both root and
model.parameters.tools; older configs only send them inmodel.parameters.tools. Previously the SDK only read root-level, leaving older configs with no tools.Test plan
model.parameters.toolswhen root key is absenttoolswins when both locations are presentmodel.parameters.toolsas array →undefinednameskipped; valid entries in same map returnedJira: AIC-1935
🤖 Generated with Claude Code