More Mockery cleanup - #61199
Open
jasonmccreary wants to merge 5 commits into
Open
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jasonmccreary
force-pushed
the
more-mockery-cleanup
branch
from
August 14, 2026 22:50
47138aa to
c6801c9
Compare
jasonmccreary
force-pushed
the
more-mockery-cleanup
branch
from
August 14, 2026 23:32
c6801c9 to
7160d79
Compare
jasonmccreary
marked this pull request as ready for review
August 14, 2026 23:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes more "Mockery cleanup" by leveraging Laravel facade's directly for testing, instead of creating a mock. While using a Facade still indirectly uses Mockery, these changes increase testing coverage for Facades and decrease direct Mockery usage.
There were also a few instances where simply using "the real thing" is fine for testing.