[13.x] Ensure dev command doesnt throw broken pipe on Windows - #61156
Draft
jackbayliss wants to merge 2 commits into
Draft
[13.x] Ensure dev command doesnt throw broken pipe on Windows#61156jackbayliss wants to merge 2 commits into
jackbayliss wants to merge 2 commits into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you use
php artisan devon Windows you when you press Ctrl C you get a big ol pipe error:Details
warp_CayYeNoTKd.mp4
This PR uses the Process facade and sets it into a process group so when you press ctrl c it terminates the whole group, and
sapi_windows_set_ctrl_handleris to ensure it catches the ctrl c.. I couldn't see anything Process wise to handle the Windows side...Details
warp_JGRaJCMUxN.mp4
Anyways, the TLDR is this only affects Wndows due to
framework/src/Illuminate/Foundation/Console/DevCommand.php
Line 67 in 0015ce4
I don't know CLI and GUI that well, so you may see a nicer way to combat this, but just thought I'd try something as felt awkward seeing a pipe error.