fix(otel): preserve external observation type on update - #1802
Closed
hassiebp wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent
update_current_span()and trace-level helper wrappers from writing a fallbacklangfuse.observation.typeonto an existing OpenTelemetry span. Third-party instrumentation can therefore retain its own observation classification while still receiving Langfuse metadata and other updates.Adds a regression test using an OpenInference instrumentation scope and
openinference.span.kind=AGENT.Linear: LFE-14798
Source report: langfuse/langfuse#15814
Verification
UV_CACHE_DIR=/tmp/langfuse-python-uv-cache uv run --frozen ruff check .UV_CACHE_DIR=/tmp/langfuse-python-uv-cache uv run --frozen mypy langfuse --no-error-summaryUV_CACHE_DIR=/tmp/langfuse-python-uv-cache uv run --frozen pytest tests/unit/test_otel.py(66 passed, 2 skipped)