feat(api): update API spec from langfuse/langfuse 8242934 - #1790
Merged
Conversation
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR updates the generated API surface for logical-root observation filtering and moves score creation to the canonical scores resource while adding legacy compatibility aliases.
isRootObservationto observation models and sync/async list filters.Confidence Score: 3/5
The PR should not merge until legacy raw-response score creation remains available alongside the high-level compatibility alias.
Removing
createfrom both legacy raw clients while continuing to expose them throughwith_raw_responsecauses existing raw-response score creation calls to fail immediately withAttributeError.Files Needing Attention: langfuse/api/legacy/score_v1/client.py and langfuse/api/legacy/score_v1/raw_client.py
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile
Context used: