Skip to content

feat(api): update API spec from langfuse/langfuse b0387f7 - #1770

Merged
wochinge merged 1 commit into
mainfrom
api-spec-bot-b0387f7
Jul 21, 2026
Merged

wochinge merged 1 commit into
mainfrom
api-spec-bot-b0387f7

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This PR adds boolean-score support to the generated metrics and dashboard-widget API surface. The main changes are:

  • Advertises the scores-boolean view in metrics clients.
  • Adds boolean-score guidance to metrics documentation.
  • Adds SCORES_BOOLEAN to dashboard-widget view enums and visitors.

Confidence Score: 4/5

The changed enum visitor API breaks existing callback-based callers and needs a compatibility fix before merging.

  • Existing calls with the old complete callback set now raise TypeError.
  • Request serialization and response parsing represent the new enum value consistently.
  • No security issue was identified in the changed code.

langfuse/api/unstable/dashboard_widgets/types/dashboard_widget_view.py and langfuse/api/unstable/dashboard_widgets/types/dashboard_widget_view_with_legacy.py

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
langfuse/api/unstable/dashboard_widgets/types/dashboard_widget_view.py:20
**Visitor Signature Breaks Existing Calls**

Existing consumers that pass the previously complete three callbacks now receive a `TypeError` because `scores_boolean` is a new required argument. The same required-argument change affects the legacy-view visitor, so upgrading the SDK breaks callers before any enum branch is dispatched.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

@langfuse-bot
langfuse-bot requested a review from wochinge July 21, 2026 14:44
@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — mechanical, auto-generated API spec sync adding the scores-boolean metrics/dashboard-widget view.

Extended reasoning...

Overview

This is an auto-generated (Fern) update syncing the Python SDK's API client with a new scores-boolean view added to the langfuse backend's metrics and dashboard-widgets APIs. Changes are confined to: docstring updates listing the new view across the legacy v1 metrics client, v2 metrics client, and dashboard-widgets client (sync + async variants), and two enum classes (DashboardWidgetView, DashboardWidgetViewWithLegacy) gaining a SCORES_BOOLEAN member plus a corresponding branch in each visit() method.

Security risks

None. No new I/O, auth, or serialization logic — purely additive enum values and documentation strings. The visit() methods are exhaustive pattern-match helpers with no external inputs beyond the enum's own variants.

Level of scrutiny

Low. This is a generated client mirroring an upstream OpenAPI/Fern spec change, structurally identical to prior similar PRs in this repo's history (e.g. adding new dimensions/views). The diff is repetitive across sync/async pairs and legacy/v2 variants, which is expected for Fern-generated code, not a sign of duplicated hand-written logic.

Other factors

The bug hunting system found nothing, and the two candidate issues it considered (stale scores-numeric docstring wording, and visit() parameter ordering) were both correctly ruled out — visit() is only ever called with keyword arguments in generated Fern clients, so inserting scores_boolean in the middle doesn't break positional callers in practice, and the scores-numeric docstring change is cosmetic wording, not a functional issue. New enum values only widen accepted input; no existing behavior is altered.

@wochinge
wochinge merged commit 11a232d into main Jul 21, 2026
21 checks passed
@wochinge
wochinge deleted the api-spec-bot-b0387f7 branch July 21, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants