feat(api): update API spec from langfuse/langfuse b0387f7 - #1770
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — mechanical, auto-generated API spec sync adding the scores-boolean metrics/dashboard-widget view.
Extended reasoning...
Overview
This is an auto-generated (Fern) update syncing the Python SDK's API client with a new scores-boolean view added to the langfuse backend's metrics and dashboard-widgets APIs. Changes are confined to: docstring updates listing the new view across the legacy v1 metrics client, v2 metrics client, and dashboard-widgets client (sync + async variants), and two enum classes (DashboardWidgetView, DashboardWidgetViewWithLegacy) gaining a SCORES_BOOLEAN member plus a corresponding branch in each visit() method.
Security risks
None. No new I/O, auth, or serialization logic — purely additive enum values and documentation strings. The visit() methods are exhaustive pattern-match helpers with no external inputs beyond the enum's own variants.
Level of scrutiny
Low. This is a generated client mirroring an upstream OpenAPI/Fern spec change, structurally identical to prior similar PRs in this repo's history (e.g. adding new dimensions/views). The diff is repetitive across sync/async pairs and legacy/v2 variants, which is expected for Fern-generated code, not a sign of duplicated hand-written logic.
Other factors
The bug hunting system found nothing, and the two candidate issues it considered (stale scores-numeric docstring wording, and visit() parameter ordering) were both correctly ruled out — visit() is only ever called with keyword arguments in generated Fern clients, so inserting scores_boolean in the middle doesn't break positional callers in practice, and the scores-numeric docstring change is cosmetic wording, not a functional issue. New enum values only widen accepted input; no existing behavior is altered.
Greptile Summary
This PR adds boolean-score support to the generated metrics and dashboard-widget API surface. The main changes are:
scores-booleanview in metrics clients.SCORES_BOOLEANto dashboard-widget view enums and visitors.Confidence Score: 4/5
The changed enum visitor API breaks existing callback-based callers and needs a compatibility fix before merging.
TypeError.langfuse/api/unstable/dashboard_widgets/types/dashboard_widget_view.py and langfuse/api/unstable/dashboard_widgets/types/dashboard_widget_view_with_legacy.py
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile