feat: support merge_insert with blob encoding column#7615
Open
nyl3532016 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge_insert directly invokes session_ctx.read_lance_unordered without specifying Blob column handling, which defaults to BlobsDescriptions. Consequently, DataFusion retrieves Blob data as a Struct type description when scanning the original dataset, causing a crash with "LargeBinary vs Struct schema mismatch!" because the table's logical schema expects LargeBinary.
Interestingly, this only happens if the input data for merge_insert lacks Blob columns; if Blob columns are present in the input, column pruning is triggered during the original data read, bypassing the Blob columns and masking the bug.