fix(index): defer scalar type validation to pylance#5219
Open
FANNG1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BTREEscalar indexesINVERTED/FTS, where the distributed layer has a clear semantic requirementBTREEand other scalar index builders reached throughcreate_index_uncommittedpa.large_string()reaches the distributed segment workflow instead of being rejected by lance-ray firstBackground
lance-format/lance#7525 added
large_string/LargeUtf8support for scalar indexes in pylance. Before this change, lance-ray could still reject the same column earlier because it mirrored a narrower Arrow type matrix increate_scalar_index.Keeping a duplicate whitelist here means lance-ray can fall behind pylance whenever scalar index type support expands. The distributed layer still validates distributed workflow concerns such as supported distributed index types, column resolution, worker count, fragment IDs, and namespace/URI inputs.
Verification