feat: forward stable row ID write configuration#5217
Draft
VibhuJawa wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Vibhu Jawa <vjawa@nvidia.com>
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward PyLance's
enable_stable_row_idsoption through every Lance-Ray write path:write_fragmentLanceFragmentWriterLanceDatasinkandLanceFragmentCommitterwrite_lanceThe option remains disabled by default, so existing callers are unchanged.
Why
Distributed writers could create and commit ordinary Lance fragments, but had no way to request stable row IDs even though PyLance supports the option at fragment-write and dataset-commit time. This prevents downstream datasets from retaining row identity across operations such as compaction.
Validation
37 passedintests/test_basic_read_write.pyandtests/test_fragment.pyThe production dataset's fresh remote URL-index initialization remained expensive; that is an index-distribution/cache concern separate from Lance-Ray's stable-row-ID write forwarding.