Skip to content

feat(ingest): observe narrow compaction preparation phases - #945

Merged
beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/wal-compaction-preparation-timing-20261120
Nov 20, 2026
Merged

beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/wal-compaction-preparation-timing-20261120

Conversation

@beinan

@beinan beinan commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Native compaction timing ends before narrow rewrite index remapping and descriptor persistence, leaving later preparation delays unclassified. Add two phases to the existing counters to expose these steps, and document that completed calls include the failed subset while cancellations are separate.

The measurements cover narrow native descriptor preparation. They do not change publication behavior or establish a performance improvement.

Refs #378.

Testing

  • 10 existing mixed-compaction tests covering concurrent updates, publication recovery and reclamation.
  • Existing phase-observation cancellation/failure test.
  • Service-feature Clippy passed.
  • Full repository CI passed locally: Rust workspace checks/tests, Python tests (236 passed, 11 skipped, 1 xfailed), Ruff and Pyright. Hosted Rust, Python and style workflows also passed at this commit.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@beinan
beinan marked this pull request as ready for review November 20, 2026 16:57
@beinan
beinan merged commit 929163e into lance-format:main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants