Skip to content

fix(wal): retain connection failure context for owner checks - #943

Merged
beinan merged 2 commits into
lance-format:mainfrom
beinan:codex/wal-owner-fence-errors-public-20261120
Nov 20, 2026
Merged

beinan merged 2 commits into
lance-format:mainfrom
beinan:codex/wal-owner-fence-errors-public-20261120

Conversation

@beinan

@beinan beinan commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Annotation owner checks can report unavailability without retaining which WAL connection step failed. Preserve the underlying cause and identify connection-pool admission, idle-connection checks, TCP connection, or TLS handshake; log the full cause chain when the owner check fails. Context is constructed only on error.

Refs #378.

Testing

  • Full repository CI script passed: workspace Rust tests, fmt and Clippy; Python tests (236 passed, 11 skipped, 1 xfailed), Ruff and Pyright.
  • Service-feature checks passed: 49 WAL client tests, 2 annotation owner-fencing tests, and Clippy for both crates.
  • The idle-connection regression verifies the added context, retained cause, and existing reconnect behavior.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ance-context-wal/src/replication/runtime/client.rs 93.75% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@beinan
beinan merged commit 88b2bac into lance-format:main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants