Conversation
Signed-off-by: LauraGPT <LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
Summary
model_quant.onnxand passquantize=Truetofunasr_onnx.SenseVoiceSmallmodel.onnxdirectories working withquantize=FalseThe official
iic/SenseVoiceSmall-onnxrepository shipsmodel_quant.onnxbut does not includechn_jpn_yue_eng_ko_spectok.bpe.model, while the existing loader used the constructor defaultquantize=False. This made the documented SenseVoice path fail even after downloading the official ONNX repository.Validation
59 passedwith the locked project environment (uv sync --extra web)git diff --checkfunasr-onnx==0.4.1wheel constructor supportsquantize: bool = FalseValidation Refresh (2026-09-29)
Rechecked unchanged head
27006d703898c7447369b745fb052f66b5618c44against main0248c84593bf66391dc2e38b4583ff72e3eae456in the project's locked Linux/Python 3.12.3 environment:uv sync --frozen --extra web --extra sensevoicecompleted successfully, including the actual optional runtime dependencies. No lockfile changes.funasr_onnx.SenseVoiceSmalland postprocessor imports succeed withfunasr-onnx==0.4.1,torch==2.11.0, andonnxruntime==1.24.4.uv pip check --python .venv/bin/python: all 95 installed packages compatible.uv run --frozen --no-sync --extra web --extra sensevoice pytest -q -ra: 59 passed, 6 dependency warnings, no skipped tests.git diff --check: passed; repository source and PR head unchanged.quantizeconstructor argument. Downloaded library wheel digests were checked against PyPI metadata.model_quant.onnxand supporting config/CMVN/token files, while the tokenizer.bpe.modelmust come fromiic/SenseVoiceSmall. Config and CMVN metadata hashes match across the two repositories.These are environment, import, unit-test, runtime-contract, and remote metadata checks. No model weights or tokenizer artifacts were downloaded, no model was loaded, and no audio inference or GPU validation was performed. Earlier Ruff/format/compile checks above are historical, not rerun as part of this refresh.
Separate Pre-existing ITN Gap
Issue #105 tracks a separate issue already present on main: the adapter sends
use_itn, but lockedfunasr-onnx==0.4.1readstextnorminstead. A no-weights probe against the actual runtime selectswoitn/ 15 for both adapter settings, while an explicittextnorm="withitn"control selects 14. Existing passing tests do not cover that transcription argument contract. This PR does not fix ITN selection; its scope remains model-directory preparation and quantization.