Label EIP-8312 UTXO frames on the transaction page - #1
Open
ilitteri wants to merge 1 commit into
Open
Conversation
A UTXO frame rendered as RESERVED(5): the mode table stops at POST_TX, so the explorer showed the frame but could not name it. Mode 5 rather than the draft's 3, because EIP-7906 already holds 3 upstream and 4 is reserved for EIP-8288. Adds a test for the whole table, including that unknown modes still render as RESERVED(n) — the package had no tests, and without one this mapping is the kind of thing that silently falls behind the next mode allocation. Verified red before the change. This is the label only. Rendering the spend payload — inputs, outputs, change index, proofs — needs an RLP decoder on this side, since dora does not consume the client's types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A UTXO frame rendered as
RESERVED(5): the mode table stops at POST_TX, so the explorer showed the frame but could not name it.Description
Adds mode 5 to
frameModeName. Mode 5 rather than the draft's 3, because EIP-7906 already holds 3 upstream and 4 is reserved for EIP-8288.Also adds the package's first test, covering the whole table including that unknown modes still render
RESERVED(n)— without one, this mapping silently falls behind the next mode allocation. Verified red before the change.Label only. Rendering the spend payload (inputs, outputs, change index, proofs) needs an RLP decoder on this side, since dora does not consume the client's types.
How to Test