Startup ordering - #397
Draft
rwb27 wants to merge 3 commits into
Draft
Conversation
Also, `attributes` is never used. I've merged it with `class_attributes` to reduce pointless duplication.
This commit adds a `start_first` attribute to `lt.thing_slot` and a simple algorithm that determines the order in which things must be started in order to fulfil those constraints. It's not guaranteed to work, and will give a helpful error if that happens.
I should probably create a common base class to deduplicate all the `__enter__` code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
Things to specify that some Thing Slots must be started first. That means the connected Thing will already be running when__enter__is called on the host Thing. This should make it easier to write code that interacts with other Things on start-up.The new syntax looks like the example in #388
Things to do before merge:
Closes #388