Specify supported Python minor versions - #395
Merged
Merged
Conversation
I've added classifiers to show the minor versions we currently support. My understanding is that capping the Python version in `requires-python` gets quite problematic, so I will leave it as a lower bound only. It already won't install on 3.14, and adding the constraint would cause it to fail with an error saying LabThings doesn't support it, rather than pointing to a problem with `pydantic`. I think the current behaviour is arguably better, and will make it easier to find out when the problem has gone away. Closes #376
Barecheck - Code coverage reportTotal: 97.43%Your code coverage diff: 0.12% ▴ ✅ All code changes are covered |
bprobert97
approved these changes
Aug 5, 2026
Contributor
|
I like this as a solution! Makes it very clear for the user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added classifiers to show the minor versions we currently support. My understanding is that capping the Python version in
requires-pythongets quite problematic, so I will leave it as a lower bound only.It already won't install on 3.14, and adding the constraint would cause it to fail with an error saying LabThings doesn't support it, rather than pointing to a problem with
pydantic. I think the current behaviour is arguably better, and will make it easier to find out when the problem has gone away.Closes #376