feature: prevent duplicate punctuation on paragraph ending - #78
Merged
Conversation
Comment on lines
+152
to
+156
| trimmed := strings.TrimRight(text, " ") | ||
| if !endsWithPunctuation(trimmed) { | ||
| lastSlateLeaf.Text = trimmed + _sentenceSeparator | ||
| } else { | ||
| lastSlateLeaf.Text = trimmed |
There was a problem hiding this comment.
bisa dibuat func aja mba biar reusable
There was a problem hiding this comment.
kalo dibikin gini giman
lastslateLeaf.Text := strings.TrimRight(text, " ")
if !endsWithPunctuation(trimmed) {
lastSlateLeaf.Text = lastslateLeaf.Text + _sentenceSeparator
}
naluthfi
force-pushed
the
feature/TEC-1085
branch
from
May 13, 2026 03:14
9f15bb9 to
eca47f7
Compare
atjhoendz
reviewed
May 13, 2026
| module github.com/kumparan/go-utils | ||
|
|
||
| go 1.26.0 | ||
| go 1.26 |
zhenqianz
approved these changes
May 13, 2026
atjhoendz
approved these changes
May 13, 2026
naluthfi
force-pushed
the
feature/TEC-1085
branch
from
May 13, 2026 04:13
eca47f7 to
e1b3468
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.