Skip to content

fix(e2e): support AWS in the build scenario - #18935

Closed
hakman wants to merge 1 commit into
kubernetes:masterfrom
hakman:e2e-build-scenario-aws
Closed

hakman wants to merge 1 commit into
kubernetes:masterfrom
hakman:e2e-build-scenario-aws

Conversation

@hakman

@hakman hakman commented Oct 27, 2026

Copy link
Copy Markdown
Member

Unblock the job while a long term fix is reviewed in #18922.

/cc @upodroid @ameukam @rifelpet

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rifelpet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2026
@ameukam

ameukam commented Oct 27, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2026
@upodroid

Copy link
Copy Markdown
Member

This doesn't solve the problem. The ec2-build staged the binaries to gs://k8s-staging-kops. My PR has an earlier commit that doesn't rely on the k/release changes(we add extra code in our deployer to copy to S3).

@upodroid

Copy link
Copy Markdown
Member

/hold

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2026
@upodroid

upodroid commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

I can:

  1. amend my PR to an earlier commit without the k/release changes
  2. mark the job as optional and not trigger it at all
  3. wait a few days for the changes to land upstream

Let me know what you want me to do

@hakman

hakman commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

@upodroid sure, go ahead with making the job optional for now.
you can also make your PR smaller, without k/release changes, if you think it helps with the review.
thanks!

@hakman

hakman commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

Abandoning this.

@hakman hakman closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants