-
Notifications
You must be signed in to change notification settings - Fork 251
Add a script to deploy CCM with kops #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @xiaoweim! |
|
Hi @xiaoweim. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaoweim The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
zhang-xuebin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this, appreciated!
tools/kops_lkg_ccm.sh
Outdated
| echo "Environment variables:" | ||
| echo " GCP_PROJECT (Required) GCP Project ID" | ||
| echo " CLUSTER_NAME (Required) Cluster name (e.g. my-cluster.k8s.local)" | ||
| echo " DELETE_CLUSTER (Optional) Set to 'false' to keep the cluster running (default: true)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this script intended for local testing? If so, is it better to set DELETE_CLUSTER default as false?
oh actually I saw you have some discussion around line 212. Probably add a usage comment section at the top and document the expected behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script is primarily for the "Cloud Provider Last Known Good Testing" framework to verify compatibility (replacing the legacy kube-up workflow). It can also be used for local testing to help reproduce these scenarios.
|
what LKG is? /assign @justinsb |
|
very cool update, thank you! |
LKG is for Last Known Good. Reference doc: https://docs.google.com/document/d/1U1YRLsAAZsVs6VyrXj8hkfA6aJp9nDZsG5NsfZ1POPE/edit?resourcekey=0-iVuzWZn3mxL2Qil-4peFFQ&tab=t.0#heading=h.fxpk50cps4zs |
|
That doc is obsolete, I've already implemented the skew testing automation, there is some internal doc and recording, but feel free to ping me I can explain it again.... In this case, we should also add a small doc explaining these things so the repo is self contained |
|
/ok-to-test |
Antonio can we have chat/meeting to go over what you have? |
| # Ensure bucket exists | ||
| if ! gsutil ls -p "${GCP_PROJECT}" "${KOPS_STATE_STORE}" >/dev/null 2>&1; then | ||
| gsutil mb -p "${GCP_PROJECT}" -l "${GCP_LOCATION}" "${KOPS_STATE_STORE}" | ||
| gsutil ubla set off "${KOPS_STATE_STORE}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? I don't see it documented in kops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see it explained here. On that note, I see a lot of shared logic between this script and ./e2e/scenarios/kops-simplethat can be refactored.
This PR introduces a script using Kops to deploy CCM, serve as a replacement for
kube-upwithin the "Cloud Provider Last Known Good Testing" framework.The "Cloud Provider LKG Testing" design addresses compatibility challenges by running continuous background tests to identify "Last Known Good" (LKG) pairs of Kubernetes and Cloud Provider code. This script uses
kopsto reliably deploy clusters for these verification tests, replacing the legacy and error-pronekube-upworkflow.lkg-k8s-local-gcp: Deploys LKG/Stable K8s with a locally built/Latest CCM (primary dev workflow).latest-k8s-lkg-gcp: Tests latest K8s with the Latest Known Good version of CCM.stock: Standard kops behavior.kops validate clusterwith a 15-minute wait to ensure the cluster is fully healthy before passing control.DELETE_CLUSTER=false.Running the script locally: https://gist.github.com/xiaoweim/f1f436e90111a25f99851fa8c809e436