fix: target metrics patches to metrics-service only

[vitorfloriano]

The Prometheus TLS patch was targetting 'Service', which was too broad and being mistakenly applied to all services, including the webhook-service, leading to a misconfig and causing errors when validating custom resources (see #276).

This PR targets the patch to the metrics-service only.

Fixes #276

/kind bug

Testing

This was manually tested by running make build-manifests-temp ENABLE_METRICS=true ENABLE_TLS=true ENABLE_WEBHOOK=true and then inspecting the generated manifest, which now features the correct config:

bin/build/manifests.yaml:

apiVersion: v1
kind: Service
metadata:
 name: nrr-webhook-service
 namespace: nrr-system
spec:
 ports:
 - name: webhook
   port: 443
   protocol: TCP
   targetPort: 9443
 selector:
   control-plane: controller-manager

Checklist

• make test passes
• make lint passes

Does this PR introduce a user-facing change?

Fix webhook port misconfig

Doc #278

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	bc91236
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a2bee14f3f8c60008339f29

[AvineshTripathi]

thanks for looking into this @vitorfloriano!

[AvineshTripathi]

probaby we should add namespace(system) too?

[vitorfloriano]

Yeah, the manual test already passed with the current fix, but better be a bit more defensive with these patches! Thanks for pointing that out.

[vitorfloriano]

Added! PTAL.

[AvineshTripathi]

thank you!

/lgtm