Skip to content

Conversation

@note35
Copy link

@note35 note35 commented Jan 20, 2026

/kind feature

What this PR does / why we need it:

This PR implements the TODO in watch.py to handle BOOKMARK events. Previously, BOOKMARK events were ignored.

Changes included:

  1. Updated unmarshal_event to extract and update resource_version when receiving BOOKMARK events.
  2. Refactored unmarshal_event using guard clauses to improve readability and reduce nesting.
  3. Added unit tests to verify bookmark handling.

Which issue(s) this PR fixes:

It fixes TODO in kubernetes/watch/watch.py, I think no issue is created for this.

Special notes for your reviewer:

Verified with python -m unittest kubernetes/watch/watch_test.py
Applied flake8 and isort on impacted lines. (No <= 80 characters limitation.)

Does this PR introduce a user-facing change?

Optimized Watch client to handle BOOKMARK events' resource version.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

Verified with python -m unittest kubernetes/watch/watch_test.py.
Applied flake8 and isort on impacted lines.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 20, 2026
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 20, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: note35 / name: Kir (4618df8)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: note35
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @note35!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants