Handle BOOKMARK events in watch.py #2505
Open
+31
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
What this PR does / why we need it:
This PR implements the TODO in watch.py to handle
BOOKMARKevents. Previously,BOOKMARKevents were ignored.Changes included:
unmarshal_eventto extract and updateresource_versionwhen receivingBOOKMARKevents.unmarshal_eventusing guard clauses to improve readability and reduce nesting.Which issue(s) this PR fixes:
It fixes TODO in kubernetes/watch/watch.py, I think no issue is created for this.
Special notes for your reviewer:
Verified with
python -m unittest kubernetes/watch/watch_test.pyApplied flake8 and isort on impacted lines. (No <= 80 characters limitation.)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A