Fix deterministic encoding with seed parameter#38
Merged
Conversation
Fixes #37 The seed parameter was documented to provide deterministic output, but the implementation was not actually deterministic because: 1. The encryption IV was always random 2. Padding bytes were always random This fix ensures that when a seed is provided: 1. The encryption IV is derived deterministically from the seed 2. Padding bytes are derived deterministically from the seed Now the same (plaintext, seed, key) combination will always produce identical ciphertext. Also updated the example to verify determinism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37
The
seedparameter inDfaEncoder.encode()was documented to provide deterministic output, but the implementation was not actually deterministic.