Removed kosli expect deployment command server/#5041#720
Open
ToreMerkely wants to merge 3 commits intomainfrom
Open
Removed kosli expect deployment command server/#5041#720ToreMerkely wants to merge 3 commits intomainfrom
ToreMerkely wants to merge 3 commits intomainfrom
Conversation
Contributor
ToreMerkely
commented
Mar 24, 2026
- Removed kosli expect deployment command server/#5041
- Updated docs. Do not print deployments in kosli log env command
- Reverted back some tabs that CC had removed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deployment-related CLI commands/output and updates documentation to reflect the new behavior (not showing deployments in environment event logs and removing deprecated deployment expectation flows).
Changes:
- Remove
kosli expect deployment(and theexpectcommand group) plus related helper/test code. - Remove
kosli list deploymentsandkosli get deploymentcommands and their golden-test fixtures. - Update docs and
kosli log env/environment events table output to no longer include “deployments”.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs.kosli.com/content/tutorials/tracing_a_production_incident_back_to_git_commits.md | Updates example kosli log env output to remove deployments column and removes deployment history lines. |
| docs.kosli.com/content/tutorials/following_a_git_commit_to_runtime_environments.md | Removes deployment references from the narrative “History” explanation. |
| docs.kosli.com/content/integrations/actions.md | Removes deployments from the webhook payload example. |
| docs.kosli.com/content/faq/_index.md | Replaces the “unknown command” example with a new one (but output format needs to match CLI). |
| cmd/kosli/testdata/output/list/list-deployments.txt | Removes golden output for removed list deployments command. |
| cmd/kosli/testdata/output/get/get-deployment.txt | Removes golden output for removed get deployment command. |
| cmd/kosli/testdata/output/get/get-deployment-latest.txt | Removes golden output for removed get deployment command. |
| cmd/kosli/testHelpers.go | Removes ExpectDeployment helper used by removed tests. |
| cmd/kosli/root.go | Removes expect command registration and deployment-related flag help strings. |
| cmd/kosli/listSnapshots.go | Removes “DEPLOYMENTS” column from environment events table (needs tab formatting fix). |
| cmd/kosli/listDeployments_test.go | Deletes tests for removed list deployments command. |
| cmd/kosli/listDeployments.go | Deletes implementation for removed list deployments command. |
| cmd/kosli/list.go | Removes list deployments subcommand registration. |
| cmd/kosli/getDeployment_test.go | Deletes tests for removed get deployment command. |
| cmd/kosli/getDeployment.go | Deletes implementation for removed get deployment command. |
| cmd/kosli/get.go | Removes get deployment subcommand registration. |
| cmd/kosli/expectDeployment_test.go | Deletes tests for removed expect deployment command. |
| cmd/kosli/expectDeployment.go | Deletes implementation for removed expect deployment command. |
| cmd/kosli/expect.go | Deletes expect command group. |
Comments suppressed due to low confidence (2)
cmd/kosli/listSnapshots.go:196
- After removing the DEPLOYMENTS column, the rows in
printEnvironmentEventsLogAsTablestill include extra trailing tab separators (e.g.\t\tand\t\t\t). This produces an extra empty column beyond the 3-column header and can lead to misaligned table output forkosli log env/kosli log environment.
Adjust the row formatting so each printed row has the same number of tab-separated columns as the header (3), and update/remove the alignment comment accordingly.
row := fmt.Sprintf("#%d\tArtifact: %s\t%s", snapshotIndex, artifactName, flow)
rows = append(rows, row)
row = fmt.Sprintf("\tFingerprint: %s\t\t", fingerprint)
rows = append(rows, row)
row = fmt.Sprintf("\tDescription: %s\t\t", description)
rows = append(rows, row)
row = fmt.Sprintf("\tReported at: %s\t\t", reportedAt)
rows = append(rows, row)
rows = append(rows, "\t\t\t") // These tabs are required for alignment
}
cmd/kosli/get.go:25
- The PR title/description doesn’t mention that the
kosli get deploymentcommand is removed here (along with its implementation and tests). If this is intentional, please explicitly call it out in the PR description (and any release notes/changelog), since it’s a user-facing breaking CLI change.
// Add subcommands
cmd.AddCommand(
newGetApprovalCmd(out),
newGetArtifactCmd(out),
newGetEnvironmentCmd(out),
newGetFlowCmd(out),
newGetSnapshotCmd(out),
newGetTrailCmd(out),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.