fix(displays): scale preview marker with keyboard size - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Displays settings preview marker so it reflects the Keyboard Size setting instead of staying at a fixed preview size. The marker remains clamped inside the display preview, including for custom positions near display edges.
Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/DisplaysSettingsPaneViewModelTests -only-testing:KeytyTests/KeyboardVisualizerSettingsTestsxcodebuild build -project Keyty.xcodeproj -scheme Keyty -configuration DebugRun project commands from
Apps/Keyty.UI Changes
Display preview marker now scales with the keyboard visualizer size setting.
Documentation
Release Notes
The display preview marker now better matches the configured keyboard overlay size.