Test on PRs, auto-deploy staging, gate prod - #8
Merged
Merged
Conversation
PRs only pytest. Push to main applies the stg stack unattended, then the existing prd environment still blocks production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv run pytest(fakes, no AWS deploy).mainwaits for tests, then auto-applies staging (environment: stg, no reviewers) and syncs a PostHog-free frontend.prdapproval gate, and does not start until staging apply succeeded.Trust / env
The staging job assumes
vars.AWS_DEPLOY_ROLE_ARNwith OIDC subjectenvironment:stg. Allow that in the deploy role trust (alongsideenvironment:prd), and create a GitHub Environment namedstgwith no required reviewers.AWS_DEPLOY_ROLE_ARNneeds to be visible to that job (repo variable, not only theprdenvironment).Test plan
prdapply job still waits for review and only then after stg succeeded