fix: preserve UTF-8 calendar snippets during sync and repair - #619
Merged
Conversation
roborev: Combined Review (
|
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar sync currently caps previews by slicing the first 200 bytes. When byte 200 falls inside a multi-byte character, the stored snippet is invalid UTF-8 and can make analytics cache reads fail.
This keeps the existing 200-byte calendar preview limit while backing up to a valid character boundary. It also extends the existing repair-encoding path to faithfully regenerate only the exact historical damage signature: an invalid 200-byte calendar snippet that is a byte-for-byte prefix of a present, valid canonical body. Other invalid snippets retain the existing generic encoding repair, and valid snippets are left untouched.
The repair command's existing full cache rebuild republishes corrected previews, so no cache schema or publication changes are needed.