Repository navigation
Observe encoded-data buffer operations through the pipeline delegate - #1047
Open
karim-alweheshy wants to merge 1 commit into
Open
karim-alweheshy wants to merge 1 commit into
karim-alweheshy wants to merge 1 commit into
Conversation
karim-alweheshy
marked this pull request as ready for review
October 28, 2026 03:04
karim-alweheshy
force-pushed
the
observe-data-buffer-updates
branch
from
November 10, 2026 11:39
22f6d0e to
090f93d
Compare
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoded-data allocation failures can leave the application with a failing allocation site but no context about the operation that preceded it. Add a synchronous pipeline-delegate hook immediately before initial reservation, resumed reservation, and append, so applications can sample their own memory diagnostics at those boundaries.
The context contains logical byte counts, the requested reservation capacity when available, and the response metadata. It exposes no body data. The callback runs on
ImagePipelineActoronce per underlying fetch operation; its default implementation is empty and pipelines with the default delegate skip it. Consumers should sample before collecting expensive metrics and return quickly.Validation: 23 macOS tests pass across the buffer-update and resumable-download suites, covering known and unknown lengths, default delegates, single-chunk responses, size rejection, and resumed prefixes. The repository CI lint command passes, and strict lint passes for the changed source files.