Repository navigation
fix(duckduckgo): mark y.js ad links as ads - #60
Open
hasandenizuk wants to merge 1 commit into
Open
hasandenizuk wants to merge 1 commit into
hasandenizuk wants to merge 1 commit into
Conversation
Some DuckDuckGo ad cards come without an ad badge, so the parser and the live search returned them as organic results. Their link still points at DuckDuckGo's ad click tracker (duckduckgo.com/y.js?ad_domain=...), so treat that link as an ad marker too, in both ParseHTML and the browser path. Fixes karust#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
duckduckgo.com/y.js?..., absolute or relative) as an ad, in bothParseHTMLand the browser search path.isDDGAdURLwith a table test, and a parser test with an ad card that has no ad badge.Why
/y.js, which only ads use.Testing
go test ./...(all packages pass; run without-race)go vet ./...and golangci-lint v1.64.8 with.golangci.ymlmake test-integration(not run: needs a browser and live DuckDuckGo; the browser path change is the same one-line check)Checklist
Fixes #59