fix(hybrid_routing): prioritize evaluated connectors in static eligible list - #354
Open
AnkitKmrGupta wants to merge 1 commit into
Open
fix(hybrid_routing): prioritize evaluated connectors in static eligible list#354AnkitKmrGupta wants to merge 1 commit into
AnkitKmrGupta wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refines static gateway extraction in src/routes/hybrid_routing.rs so the final “static eligible” connector list is deterministic and prioritizes connectors that appear in evaluated_output, while still including all originally eligible connectors.
Changes:
- Prefer
evaluated_outputconnectors (filtered to the eligible set) ahead of the originaleligible_connectors. - De-duplicate connectors while preserving the final ordering.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+66
to
+80
| let eligible = &response.eligible_connectors; | ||
| let mut ordered = Vec::with_capacity(eligible.len()); | ||
|
|
||
| for connector in response | ||
| .evaluated_output | ||
| .iter() | ||
| .filter(|evaluated| eligible.contains(evaluated)) | ||
| .chain(eligible) | ||
| { | ||
| if !ordered.contains(connector) { | ||
| ordered.push(connector.clone()); | ||
| } | ||
| } | ||
|
|
||
| ordered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for extracting eligible gateways in
src/routes/hybrid_routing.rs. The updated implementation ensures that connectors from theevaluated_outputfield are prioritized and ordered without duplicates, while still including all originally eligible connectors.Improvements to gateway extraction logic:
extract_static_eligible_gatewaysfunction now combines connectors fromevaluated_output(filtered to those ineligible_connectors) with the originaleligible_connectorslist, ensuring no duplicates and preserving order. This change improves the accuracy and determinism of gateway selection.