PopupMenu: Make manually-triggered custom items keyboard-accessible - #1698
Open
emezeske wants to merge 1 commit into
Open
PopupMenu: Make manually-triggered custom items keyboard-accessible#1698emezeske wants to merge 1 commit into
emezeske wants to merge 1 commit into
Conversation
Custom items created with isTriggeredAutomatically=false handle their own mouse clicks, but the arrow keys skipped over them and return/space could not activate them, so menus containing them were unusable from the keyboard. Allow them to be highlighted like any other item and let return/space dismiss the menu with the item's ID, exactly as CustomComponent::triggerMenuItem() would. Mouse behaviour is unchanged.
emezeske
marked this pull request as ready for review
August 8, 2026 21:01
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom menu items created with isTriggeredAutomatically=false handle their own mouse clicks, but the arrow keys skip over them and return/space cannot activate them, so a menu containing them is unusable from the keyboard.
This lets them be highlighted like any other item and makes return/space dismiss the menu with the item's ID, which is exactly what CustomComponent::triggerMenuItem() does. Mouse handling still goes through canBeTriggered(), so nothing changes there.