Skip to content

fix a bug in the amd module definition#687

Closed
deleonio wants to merge 1 commit into
jtblin:masterfrom
deleonio:master
Closed

fix a bug in the amd module definition#687
deleonio wants to merge 1 commit into
jtblin:masterfrom
deleonio:master

Conversation

@deleonio
Copy link
Copy Markdown

@deleonio deleonio commented Mar 6, 2018

Description of change

Pull Request check-list

  • Run gulp test to ensure there are no linting, or style issues and all tests pass.
  • Squash your commits into a few commits only.
  • Make sure the commit message is short, concise and descriptive of the issues you're fixing.
  • Avoid mixing up multiple issues and/or features, open one pull request for each issue.
  • Have you updated the documentation and / or examples?
  • Have you included a new test?

@deleonio
Copy link
Copy Markdown
Author

deleonio commented Mar 6, 2018

It fix the loading issue.

@jtblin jtblin deleted the branch jtblin:master April 29, 2026 05:26
@jtblin jtblin closed this Apr 29, 2026
@jtblin
Copy link
Copy Markdown
Owner

jtblin commented Apr 29, 2026

This PR was automatically closed following the migration to the main branch and the deletion of the master branch.

With the recent transition to a modern Rollup-based build system, the AMD/module definition logic has been entirely refactored, rendering this fix obsolete. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants