Skip to content

update chart.js dependency#632

Closed
csulok wants to merge 1 commit into
jtblin:mainfrom
csulok:master
Closed

update chart.js dependency#632
csulok wants to merge 1 commit into
jtblin:mainfrom
csulok:master

Conversation

@csulok
Copy link
Copy Markdown

@csulok csulok commented May 25, 2017

Description of change

Updated the chart.js dependency to 2.5. Nothing more.

Pull Request check-list

  • Run gulp test to ensure there are no linting, or style issues and all tests pass.
  • Squash your commits into a few commits only.
  • Make sure the commit message is short, concise and descriptive of the issues you're fixing.
  • Avoid mixing up multiple issues and/or features, open one pull request for each issue.
  • Have you updated the documentation and / or examples?
  • Have you included a new test?

@csulok csulok mentioned this pull request May 25, 2017
3 tasks
@jtblin
Copy link
Copy Markdown
Owner

jtblin commented May 29, 2017

Waiting on chartjs/Chart.js#4079

@GustavoCarvalho
Copy link
Copy Markdown

Is there any example of candlestick?

@dbradley771
Copy link
Copy Markdown

chartjs/Chart.js#4079 seems to be completed, can this upgrade be merged?

@jtblin jtblin deleted the branch jtblin:main April 29, 2026 05:26
@jtblin jtblin closed this Apr 29, 2026
@jtblin jtblin reopened this Apr 29, 2026
@jtblin jtblin changed the base branch from master to main April 29, 2026 10:42
@jtblin
Copy link
Copy Markdown
Owner

jtblin commented Apr 29, 2026

Thank you for your contribution! This change has already been implemented or superseded by more recent dependency updates. We are currently on Chart.js v2.9.4 and have updated the CDN links in the documentation. Closing this PR.

@jtblin jtblin closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants