Adding STRICT_MODE option for jsonpath filters#941
Open
wildMythicWest wants to merge 3 commits intojson-path:masterfrom
Open
Adding STRICT_MODE option for jsonpath filters#941wildMythicWest wants to merge 3 commits intojson-path:masterfrom
wildMythicWest wants to merge 3 commits intojson-path:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
|
@kallestenflo Can we merge a strict option? We very much need it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Issue 940
If we have some data
Map<String, Object> check = new HashMap<String, Object>(); check.put("item", 3); check.put("null_item", null);and we use this filter
filter(where("not_existent_item").nin(3)).apply(createPredicateContext(check))I expect to get false because no such element exists.
Instead the filter returns true.
This PR adds a new STRICT_MODE Option that will validate that all attributes in the filter are present in the json. If an attribute is not present, the filter will return false. This is a fix to NIN specifically. Because NIN inverts the output of IN there is no check if the attribute actually exists in the json.
Adding this mode will not change existing behavior.