This repository was archived by the owner on Jan 16, 2020. It is now read-only.
Updated to v2.1 from the plugin site and fixed a potential bug. - #3
Open
Craga89 wants to merge 5 commits into
Open
Updated to v2.1 from the plugin site and fixed a potential bug.#3Craga89 wants to merge 5 commits into
Craga89 wants to merge 5 commits into
Conversation
…it in case we need to re-read later with a different metadata type.
|
Yes, please merge this in... |
|
I have patches waiting to come in... please merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub repo needed updating to the latest 2.1 version. Whilst I was doing this I cleaned up the code and optimized it a bit so JSLint is happy!
Also, I added a fix that prevents an empty metadata object from being stored, which was preventing the metadata from being re-read with a different 'type' option if no data was found!
-Craig