fix(Sylius): Fix media get path#121
Open
loic425 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Normally, the media path is now synchronized with the path via the ImageUploader. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Sylius bridge to resolve image paths from the underlying Media object, aiming to fix cases where the legacy image path does not reflect the current media path.
Changes:
- Update the Sylius admin product image helper template to read the path from
image.media.path. - Add a
getPath()method toEntityWithMediaImageTraitto return the media path when available, with a fallback to a legacypathproperty when present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Bridge/Sylius/templates/admin/shared/helper/product_image.html.twig | Switches admin product image URL source to image.media.path. |
| src/Bridge/Sylius/src/Doctrine/ORM/EntityWithMediaImageTrait.php | Adds a getPath() accessor that prefers media->getPath() and falls back to legacy path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've challenged with ChatGPT but this solution seems to be the most pragmatic one.