feat(Sylius): Move a directory#118
Open
loic425 wants to merge 2 commits into
Open
Conversation
loic425
force-pushed
the
feat/move-directory
branch
from
9f60f1f to
90d7fbc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the Sylius admin media explorer to move a directory via the existing folder selector modal, including a new controller endpoint and UI action, plus translations and a functional test.
Changes:
- Add
moveDirectory()admin endpoint (POST) that moves a folder and redirects similarly to rename. - Add Sylius admin UI pieces (grid action + modal via twig hooks) to select a target folder and submit the move.
- Add EN/FR translations and a new functional test covering moving a directory.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Bridge/Sylius/Admin/Controller/MediaAdminControllerTest.php | Adds functional test for moving a directory (has issues to fix). |
| src/Bridge/Sylius/translations/JoliMediaSyliusBundle.fr.yaml | Adds labels/messages for “move directory”. |
| src/Bridge/Sylius/translations/JoliMediaSyliusBundle.en.yaml | Adds labels/messages for “move directory”. |
| src/Bridge/Sylius/templates/admin/shared/helper/move_directory_modal.html.twig | Introduces shared modal + hidden move form for directory moves. |
| src/Bridge/Sylius/templates/admin/media/index/modal/move_directory_modal.html.twig | Wires the shared modal into the media index hook context. |
| src/Bridge/Sylius/templates/admin/media/grid/action/rename_directory.html.twig | Refactors rename action to use the shared button helper with tooltip. |
| src/Bridge/Sylius/templates/admin/media/grid/action/move_directory.html.twig | Adds new grid action button to trigger directory move flow. |
| src/Bridge/Sylius/templates/admin/media/grid/action/delete_directory.html.twig | Switches delete directory action to icon-only. |
| src/Bridge/Sylius/templates/admin/media/grid/action/create_directory.html.twig | Refactors create directory action to use the shared button helper with tooltip. |
| src/Bridge/Sylius/src/Admin/Grid/MediaGrid.php | Registers the new move_directory grid action. |
| src/Bridge/Sylius/src/Admin/Controller/MediaAdminController.php | Adds /move-directory route and move handling logic. |
| src/Bridge/Sylius/config/app/twig_hooks/media/index.php | Injects the move-directory modal into the media index hook. |
| src/Bridge/src/Twig/JoliMediaAdminExtension.php | Adds a Twig filter used by the move-directory action template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loic425
force-pushed
the
feat/move-directory
branch
from
dc55197 to
57b6bcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move_folder.mov