Skip to content

fix(security): skip symlinks in discovery to prevent exfiltration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cedric-appdirect wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): skip symlinks in discovery to prevent exfiltration #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,20 @@ export async function discoverSkills(repoPath: string): Promise<SkillInfo[]> {

const fullPath = path.join(dir, entry.name)

if (entry.isDirectory()) {
if (entry.isDirectory() && !entry.isSymbolicLink()) {
const skillMdPath = path.join(fullPath, "SKILL.md")

if (fs.existsSync(skillMdPath)) {
let skillMdStat: fs.Stats
try {
skillMdStat = fs.lstatSync(skillMdPath)
if (!skillMdStat.isFile()) continue // Skip symlinked SKILL.md
} catch {
// SKILL.md does not exist - recurse into subdirectory
findSkills(fullPath)
continue
}

if (skillMdStat.isFile()) {
// Extract skill name from the directory path relative to skill/
const relativePath = path.relative(skillDir, fullPath)
const skillName = relativePath.replace(/\//g, "-")
Expand All @@ -223,9 +233,6 @@ export async function discoverSkills(repoPath: string): Promise<SkillInfo[]> {
path: fullPath,
description,
})
} else {
// Recurse into subdirectory
findSkills(fullPath)
}
}
}
Expand Down Expand Up @@ -298,9 +305,9 @@ export async function discoverAgents(repoPath: string): Promise<AgentInfo[]> {

const fullPath = path.join(dir, entry.name)

if (entry.isDirectory()) {
if (entry.isDirectory() && !entry.isSymbolicLink()) {
findAgents(fullPath, depth + 1)
} else if (entry.name.toLowerCase().endsWith(".md")) {
} else if (entry.isFile() && entry.name.toLowerCase().endsWith(".md")) {
// Check file size before reading
try {
const stats = fs.statSync(fullPath)
Expand Down Expand Up @@ -456,9 +463,9 @@ export async function discoverCommands(repoPath: string): Promise<CommandInfo[]>

const fullPath = path.join(dir, entry.name)

if (entry.isDirectory()) {
if (entry.isDirectory() && !entry.isSymbolicLink()) {
findCommands(fullPath, depth + 1)
} else if (entry.name.toLowerCase().endsWith(".md")) {
} else if (entry.isFile() && entry.name.toLowerCase().endsWith(".md")) {
// Check file size before reading
try {
const stats = fs.statSync(fullPath)
Expand Down Expand Up @@ -614,9 +621,9 @@ export async function discoverPlugins(repoPath: string, repoShortName: string):

const fullPath = path.join(dir, entry.name)

if (entry.isDirectory()) {
if (entry.isDirectory() && !entry.isSymbolicLink()) {
findPlugins(fullPath, depth + 1)
} else if (entry.name.toLowerCase().endsWith(".ts") || entry.name.toLowerCase().endsWith(".js")) {
} else if (entry.isFile() && (entry.name.toLowerCase().endsWith(".ts") || entry.name.toLowerCase().endsWith(".js"))) {
// Check file size before processing
try {
const stats = fs.statSync(fullPath)
Expand Down