[laurenverity]

Problem

jf ruby bundle fails when the configured username contains @, which is the normal case for email-style Artifactory usernames. Bundler can't apply the credential the CLI passes it, because setting it as the source URI's userinfo raises:

URI::InvalidComponentError: bad component(expected userinfo component or user component): jane@example.com

Fix

Adds ruby.BundleCredential, which percent-encodes the username and password separately and uses it for both the injected env var and the config entry created in setup.

Testing

Added new tests that cover both cases.

• All tests passed. If this feature is not already covered by the tests, I added new tests.
• All static analysis checks passed.
• Appropriate label is added to auto generate release notes.
• I used gofmt for formatting the code before submitting the pull request.
• PR description is clear and concise, and it includes the proposed solution/fix.

Summary by CodeRabbit

• Bug Fixes
  • Ruby Bundler credentials now safely encode usernames and passwords containing spaces or reserved characters, including email-style usernames. This helps prevent special characters from being misinterpreted during authentication. Empty usernames are also handled by the credential encoding.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Bundler credentials now use a shared helper that percent-encodes usernames and passwords separately. Ruby auth injection and Ruby setup use the helper, and tests cover encoded credentials.

Changes: Bundler Credential Encoding

Layer / File(s)	Summary
Credential helper and auth injection artifactory/commands/ruby/native_ruby.go, artifactory/commands/ruby/native_ruby_test.go	BundleCredential percent-encodes usernames and passwords separately and replaces + with %20 for spaces. Ruby auth injection uses the helper. Tests cover reserved characters, spaces, empty usernames, and email-style usernames.
Ruby setup integration artifactory/commands/setup/setup.go, artifactory/commands/setup/setup_test.go	Ruby setup uses BundleCredential for per-host Bundler credentials. A test checks the encoded email username and password.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: bug

Merge Risk: Minimal · up to dc89c

No actionable merge-blocking risk is established for this credential-encoding change; it is mergeable with normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: fixing Bundler credentials for usernames that contain '@'.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI; Enforced overrides: Organization, Workspace
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4007e997-ce3c-4e71-8629-493097565af3

Commits

Reviewing files that changed from the base of the PR and between 30c80a7 and dc89cef.

Files selected for processing: 4

• artifactory/commands/ruby/native_ruby.go
• artifactory/commands/ruby/native_ruby_test.go
• artifactory/commands/setup/setup.go
• artifactory/commands/setup/setup_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[laurenverity]

I have read the CLA Document and I hereby sign the CLA

[udaykb2]

Hi @laurenverity , thank you for your contribution.

Instead of creating the PR from a fork, could you create it from a branch of this repository? We cannot run the CLI integration tests from a PR that comes from a fork.

[laurenverity]

Hi @laurenverity , thank you for your contribution.

Instead of creating the PR from a fork, could you create it from a branch of this repository? We cannot run the CLI integration tests from a PR that comes from a fork.

Hi @udaykb2! Unfortunately I cannot push a branch due to not having appropriate permissions on this repo, it seems. What should I do in light of that?

[udaykb2]

Hi @laurenverity , I ran integration tests on this PR. These changes will be available in upcoming CLI release (probably by next week).

[github-actions]

---

🐸 JFrog Frogbot