Skip to content

Fix latest upstream image texture uploads #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jebos merged 2 commits into from
May 28, 2026
Merged

Fix latest upstream image texture uploads #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ecfc4c
Fix latest upstream image texture uploads
jebos May 28, 2026
ea07bab
Fix upstream decoder include path
jebos May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmake/RiveThirdParty.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ target_include_directories(rive_official
"${RIVE_CPP_DIR}/renderer/src"
"${RIVE_CPP_DIR}/renderer/glad/include"
"${RIVE_CPP_DIR}/renderer/glad"
"${RIVE_CPP_DIR}/decoders/include"
"${RIVE_CPP_DIR}/tests/include"
"${RIVE_DIRECTX_HEADERS_DIR}/include"
"${RIVE_DIRECTX_HEADERS_DIR}/include/directx"
Expand Down
2 changes: 1 addition & 1 deletion scripts/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

RIVE_RUNTIME_PATH = "3rdparty/rive-cpp"
RIVE_RUNTIME_URL = "https://github.com/rive-app/rive-runtime.git"
RIVE_RUNTIME_REV = "ff55eced3d97ebdef70c88a679389697fcc061f4"
RIVE_RUNTIME_REV = "64313541caeb1f38a299b89bc3cd8b5b42794fe5"
RIVE_RUNTIME_CHECK = "include/rive/file.hpp"
RIVE_RUNTIME_ENV = "RIVEQT_RIVE_RUNTIME_REV"

Expand Down
1 change: 1 addition & 0 deletions src/RiveQtQuick/private/rendering/rived3d12bridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ rive::rcp<rive::RenderImage> RiveD3D12Bridge::createRenderImage(
auto texture = impl->makeImageTexture(static_cast<uint32_t>(rgba.width()),
static_cast<uint32_t>(rgba.height()),
1,
rive::GPUTextureFormat::rgba32,
rgba.constBits());
return rive::make_rcp<rive::RiveRenderImage>(texture);
}
Expand Down
1 change: 1 addition & 0 deletions src/RiveQtQuick/private/rendering/riveglbridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ rive::rcp<rive::RenderImage> RiveGLBridge::createRenderImage(
static_cast<uint32_t>(rgba.width()),
static_cast<uint32_t>(rgba.height()),
1,
rive::GPUTextureFormat::rgba32,
rgba.constBits());
return rive::make_rcp<rive::RiveRenderImage>(texture);
}
Expand Down
1 change: 1 addition & 0 deletions src/RiveQtQuick/private/rendering/rivemetalbridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ Handle objcHandleFromObject(quint64 object)
static_cast<uint32_t>(rgba.width()),
static_cast<uint32_t>(rgba.height()),
1,
rive::GPUTextureFormat::rgba32,
rgba.constBits());
return rive::make_rcp<rive::RiveRenderImage>(texture);
}
Expand Down
1 change: 1 addition & 0 deletions src/RiveQtQuick/private/rendering/rivevulkanbridge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ rive::rcp<rive::RenderImage> RiveVulkanBridge::createRenderImage(
auto texture = impl->makeImageTexture(static_cast<uint32_t>(rgba.width()),
static_cast<uint32_t>(rgba.height()),
1,
rive::GPUTextureFormat::rgba32,
rgba.constBits());
return rive::make_rcp<rive::RiveRenderImage>(texture);
}
Expand Down
Loading