Conversation
jbaublitz
requested changes
Nov 12, 2025
jbaublitz
left a comment
jbaublitz
left a comment
Owner
There was a problem hiding this comment.
I'm going though the code now but for the time being, would you be able to add a test case using the global prefix option as well?
Author
|
Sounds good. I’ll get on it this weekend
…-------- Original Message --------
On Wednesday, 11/12/25 at 15:47 John Baublitz ***@***.***> wrote:
@jbaublitz requested changes on this pull request.
I'm going though the code now but for the time being, would you be able to add a test case using the global prefix option as well?
—
Reply to this email directly, [view it on GitHub](#129 (review)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACZBPVR2E2RKQ2DY27BMMFT34OMH5AVCNFSM6AAAAACFGK477KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINJVGQ2DOOBYHE).
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Author
Added the test |
Owner
|
Okay, I'll try to continue review this weekend. |
jbaublitz
requested changes
Dec 4, 2025
jbaublitz
left a comment
jbaublitz
left a comment
Owner
There was a problem hiding this comment.
Just one minor comment and then I'll merge this.
| syn::punctuated::Punctuated::<syn::Meta, syn::Token![,]>::parse_terminated, | ||
| ) { | ||
| meta_list.into_iter().find_map(|meta| { | ||
| if meta.path().is_ident("prefix") { |
Owner
There was a problem hiding this comment.
I think this if statement is redundant.
Owner
|
It also looks like there's a CI failure. |
Author
|
I’ll hop on this over the weekend. CI failure is weird
…-------- Original Message --------
On Friday, 12/05/25 at 13:33 John Baublitz ***@***.***> wrote:
jbaublitz left a comment [(jbaublitz/getset#129)](#129 (comment))
It also looks like there's a CI failure.
—
Reply to this email directly, [view it on GitHub](#129 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACZBPVVR4H4CUWQQXVKXS5T4AHFV5AVCNFSM6AAAAACFGK477KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJYGA2TGNRWGI).
You are receiving this because you were assigned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#128
Support for custom prefixes on getters will be very helpful for various use cases, including mocks for testing.